Add a CLI test for MRVA with multiple queries#3354
Merged
robertbrignull merged 4 commits intomainfrom Feb 14, 2024
Merged
Conversation
Contributor
|
Generally looking good. Let's make sure the tests pass in the various versions of the CLI that we expect them too. Would be good to run the CLI tests workflow against your branch. |
Contributor
Author
Good point the test should only run on supported CLI versions. I'm a bit confused why it's currently failing on the latest CLI version as it passed locally. I'll take a look. |
Contributor
Author
|
Run of all CLI tests: https://github.com/github/vscode-codeql/actions/runs/7900721664 (updated) |
02b34cc to
2138f85
Compare
Contributor
Author
|
The CLI tests are all green. Should be ready for re-review now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a simple test for running MRVA with two queries. This was actually quite easy because we can re-use the
doVariantAnalysisTestmethod with only very small changes.There are more edge cases of course, but I think they're mostly covered by the no-workspace integration tests. In the CLI tests which are even slower to run, I hope it's ok to just run a single MRVA with two queries and that shows that the process works.
There is already a test for running queries from a published pack, so we don't need to add anything more for that.
Checklist
ready-for-doc-reviewlabel there.